-
Notifications
You must be signed in to change notification settings - Fork 521
Port DataLoader to TypeScript #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NShahri
wants to merge
18
commits into
graphql:main
Choose a base branch
from
NShahri:typescript
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b0814f9
upgrade packages including eslint, jest and changesets, install types…
NShahri 910c937
use tsup to build/watch the package
NShahri a454ec2
fix the eslint config and script
NShahri fab2884
fix prettier config
NShahri ed9862a
fix the jest config and enaable ESM for jest
NShahri faf3fb0
mirate to typescript
NShahri b73bb0b
remove not required files like flow,jest,yarn and babel configs
NShahri 05c662a
refactor: make DataLoader properties private and define move some met…
NShahri 6da3bbb
Implement custom handler for unhandled promise rejections in Jest tests
NShahri 028d3c9
Switch from Yarn to NPM for dependency installation
NShahri 9fc234f
Update validation workflow name and trigger events
NShahri ca45b68
Fix command syntax for running CI tests in validation.yml
NShahri 6374f4a
use global dependency when DataLoader initiated, refactor tests for e…
NShahri 509a351
skip unhandled rejections test
NShahri 523fde1
replace tsup with tsdown
NShahri da5bfb8
use Node’s type stripping for development, tsc for build
NShahri 1308818
update package.json to correct paths for module exports, cleanup
NShahri 9f96722
change the output file structure and extension
NShahri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"main": "dist/index.js",
"module": "dist/index.mjs",
Can we extract this as mjs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @productdevbook
Unfortunately,
TypeScriptdoesn’t provide a built-in way to enforce specific file extensions, so implemented a custom postbuild script to handle that.This is one of the advantages of using a tool like
tsdown, as it abstracts these details and simplifies the build process.