-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make parsing publicly accessible #776
base: master
Are you sure you want to change the base?
Make parsing publicly accessible #776
Conversation
Adds a parse method on GraphQLRequest Exposes and documents types that make that possible: Document, Spanning and ParseError
adds a very simple example that does not use any frameworks and just demonstrates how the library works on its own
# Conflicts: # juniper/src/lib.rs
I think we could kill two birds with one stone if instead of adding a I think it's also worth it to look into eliminating the schema / scalar template parameter requirement from parsing before making |
Thanks @ccbrown! I'm not sure I understand where you're suggesting to add the method. Are you suggesting that:
Regarding the |
Just 2. Then delete the parse method because we could just use the existing
Sounds good to me. 👍 |
Partial fix for #726
Reference #773
I've added
parse
as a public method on theGraphQLRequest
type. I've documented and exposedDocument
,Spanning
andParseError
to allow working with the resulting type.