Expose the operation name from juniper_rocket::GraphQLRequest

[davidpdrsn]

Measuring the runtime of queries will only tell if there are slow
queries. To find out which queries are slow you need the operation name.

Getting the operation name was previously not possible from a Rocket
request handler. This fixes that.

I ran into this issue recently when implementing performance performance
monitoring for an app using juniper-rocket.

[codecov-io]

Codecov Report

Merging #353 into master will decrease coverage by 1.95%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   88.32%   86.37%   -1.96%     
==========================================
  Files         103      105       +2     
  Lines       14922    15373     +451     
==========================================
+ Hits        13180    13278      +98     
- Misses       1742     2095     +353

Impacted Files	Coverage Δ
juniper/src/http/mod.rs	0% <ø> (ø)	⬆️
juniper_rocket/src/lib.rs	90% <93.75%> (+0.23%)	⬆️
juniper/src/macros/object.rs	42.42% <0%> (-52.58%)	⬇️
juniper_codegen/src/util.rs	30.57% <0%> (-38.27%)	⬇️
juniper/src/http/playground.rs	0% <0%> (-25%)	⬇️
juniper/src/parser/tests/value.rs	91.04% <0%> (-5.95%)	⬇️
juniper/src/parser/tests/document.rs	93.1% <0%> (-2.3%)	⬇️
juniper/src/macros/interface.rs	88.63% <0%> (-2.28%)	⬇️
juniper/src/integrations/serde.rs	57.89% <0%> (-0.76%)	⬇️
juniper/src/types/base.rs	91.01% <0%> (-0.7%)	⬇️
... and 34 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794568e...84c410d. Read the comment docs.

[theduke]

Looks good.

Two nits:

• Formatting is failing (please run cargo fmt on stable)
• also update the juniper changelog

[davidpdrsn]

@theduke Done

[LegNeato]

Looks great! Please add an integration test for juniper and juniper_rocket to make sure we don't regress in the future.

[LegNeato]

Wouldn't we want a list of operations for batch requests for the same usecase?

[davidpdrsn]

Yeah that is true. Fixed in 168a763

[davidpdrsn]

cargo test fails for me on nightly, which is necessary for rocket to work. Not quite sure what is wrong. I get this output

$ cargo test
warning: /Users/davidpdrsn/dev/major/juniper-fork/integration_tests/juniper_tests/Cargo.toml: file found to be present in multiple build targets: /Users/davidpdrsn/dev/major/juniper-fork/integration_tests/juniper_tests/src/lib.rs
   Compiling juniper_hyper v0.2.0 (/Users/davidpdrsn/dev/major/juniper-fork/juniper_hyper)
error: internal compiler error: src/librustc_mir/borrow_check/nll/universal_regions.rs:741: cannot convert `ReScope(Node(257))` to a region vid

thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:637:9
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
error: aborting due to previous error


note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.36.0-nightly (3f5152e20 2019-05-08) running on x86_64-apple-darwin

note: compiler flags: -C debuginfo=2 -C incremental --crate-type bin

note: some of the compiler flags provided by cargo are hidden

error: Could not compile `juniper_hyper`.
warning: build failed, waiting for other jobs to finish...
error: internal compiler error: src/librustc_mir/borrow_check/nll/universal_regions.rs:741: cannot convert `ReScope(Node(257))` to a region vid

thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:637:9
note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
error: aborting due to previous error


note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.36.0-nightly (3f5152e20 2019-05-08) running on x86_64-apple-darwin

note: compiler flags: -C debuginfo=2 -C incremental

note: some of the compiler flags provided by cargo are hidden

error: Could not compile `juniper_hyper`.

To learn more, run the command again with --verbose.

Exact toolchain is rustc 1.36.0-nightly (3f5152e20 2019-05-08)

[LegNeato]

The bug you are hitting is rust-lang/rust#59344.

[davidpdrsn]

It seems a solution was recently merged. I'll give it another shot on the latest nightly.

[davidpdrsn]

I have added an integration test now. I wasn't quite sure if it also made sense to test the path where there is no operation name provided. I decided to trust the typesystem 😊 Let me know if you would like that.

[LegNeato]

Thanks!