-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the canonical introspection query #337
Conversation
bbf4b6b
to
92adccd
Compare
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 87.73% 88.31% +0.57%
==========================================
Files 101 103 +2
Lines 14255 14853 +598
==========================================
+ Hits 12507 13117 +610
+ Misses 1748 1736 -12
Continue to review full report at Codecov.
|
👍 LGTM |
@LegNeato actually, why do we need the with description / no description split? |
@theduke I don't know, I just followed what graphqljs did. I would imagine it is probably for space savings? |
@theduke confirmed with the GraphQL.js team that it to save data/space when the result is read by a machine. If the target is a dev tool that wants descriptions then you include them, but if the target is a code generator that doesn't need them then you can save the download bytes. |
Fixes #307.
I also fixed all the book tests to run and I am too lazy to put them in a different PR 🤷♂️