Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the canonical introspection query #337

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

LegNeato
Copy link
Member

@LegNeato LegNeato commented Apr 4, 2019

Fixes #307.

I also fixed all the book tests to run and I am too lazy to put them in a different PR 🤷‍♂️

@LegNeato LegNeato requested a review from theduke April 4, 2019 06:17
@LegNeato LegNeato added the enhancement Improvement of existing features or bugfix label Apr 4, 2019
@LegNeato LegNeato force-pushed the json_schema branch 2 times, most recently from bbf4b6b to 92adccd Compare April 4, 2019 06:20
@LegNeato LegNeato changed the title Add support for the canonical introspection schema Add support for the canonical introspection query Apr 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #337 into master will increase coverage by 0.57%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #337      +/-   ##
==========================================
+ Coverage   87.73%   88.31%   +0.57%     
==========================================
  Files         101      103       +2     
  Lines       14255    14853     +598     
==========================================
+ Hits        12507    13117     +610     
+ Misses       1748     1736      -12
Impacted Files Coverage Δ
juniper/src/lib.rs 87.09% <100%> (+6.14%) ⬆️
juniper/src/tests/schema_introspection.rs 100% <100%> (ø)
juniper/src/tests/introspection_tests.rs 94.5% <100%> (+0.99%) ⬆️
juniper/src/introspection/mod.rs 100% <100%> (ø)
juniper/src/http/playground.rs 0% <0%> (-25%) ⬇️
juniper/src/http/graphiql.rs 0% <0%> (-20%) ⬇️
juniper/src/schema/model.rs 90.65% <0%> (+3.27%) ⬆️
juniper/src/schema/schema.rs 93.45% <0%> (+6.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5341e2...d836cf9. Read the comment docs.

@graphql-rust graphql-rust deleted a comment from codecov-io Apr 4, 2019
@theduke
Copy link
Member

theduke commented Apr 4, 2019

👍

LGTM

@theduke theduke merged commit e11d0d2 into graphql-rust:master Apr 4, 2019
@theduke
Copy link
Member

theduke commented Apr 4, 2019

@LegNeato actually, why do we need the with description / no description split?

@LegNeato
Copy link
Member Author

LegNeato commented Apr 4, 2019

@theduke I don't know, I just followed what graphqljs did. I would imagine it is probably for space savings?

@LegNeato LegNeato deleted the json_schema branch April 4, 2019 14:13
@LegNeato
Copy link
Member Author

LegNeato commented Apr 4, 2019

@theduke confirmed with the GraphQL.js team that it to save data/space when the result is read by a machine. If the target is a dev tool that wants descriptions then you include them, but if the target is a code generator that doesn't need them then you can save the download bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement introspection schema.json generation
3 participants