Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lifetime annotations when using derives #226

Merged
merged 2 commits into from
Aug 27, 2018

Conversation

LegNeato
Copy link
Member

Fixes #225

@codecov-io
Copy link

codecov-io commented Aug 20, 2018

Codecov Report

Merging #226 into master will decrease coverage by 0.23%.
The diff coverage is 51.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   89.89%   89.65%   -0.24%     
==========================================
  Files          96       96              
  Lines       18167    18311     +144     
==========================================
+ Hits        16331    16417      +86     
- Misses       1836     1894      +58
Impacted Files Coverage Δ
juniper_codegen/src/derive_object.rs 0% <0%> (ø) ⬆️
juniper_codegen/src/derive_input_object.rs 0% <0%> (ø) ⬆️
juniper_tests/src/codegen/derive_object.rs 89.75% <100%> (+0.56%) ⬆️
juniper_tests/src/codegen/derive_input_object.rs 78.21% <51.51%> (-15.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04b06f...f64ca47. Read the comment docs.

@djc
Copy link
Contributor

djc commented Aug 22, 2018

Drive-by review: this looks great! Thanks for fixing my issue. 👍

@LegNeato LegNeato requested review from mhallin and theduke August 22, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants