Abstract (start, end) from Spanning struct into new struct Span #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audunhalland
force-pushed
the
spanning-span
branch
from
1550f17 to
e775873
Compare
Closed
audunhalland
force-pushed
the
spanning-span
branch
from
e775873 to
d814053
Compare
tyranron
added
enhancement
audunhalland
force-pushed
the
spanning-span
branch
from
d814053 to
78f885b
Compare
tyranron
requested changes
Nov 9, 2023
There was a problem hiding this comment.
@audunhalland please, make this PR editable for maintainers:
|
The checkbox isn't visible for me. Could it be because the fork is owned by an organization in which I'm not an administrator? 🤔 Perhaps it's better if I re-create the PR from my personal fork. |
audunhalland
force-pushed
the
spanning-span
branch
from
78f885b to
70cd07b
Compare
|
New PR up at #1208 (from a my personal fork). Sorry for the noise 😿 The "Allow edits" github bug is discussed here: https://github.com/orgs/community/discussions/5634 |
tyranron
added
duplicate
|
@audunhalland thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to treat the source region (the Span) separately from the spanned item in
Spanning.