Remove #[cfg(tests)] from build.rs #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure is due to rustfmt. I don't know how much longer skeptic makes the builds, but I think the priority is fixing this so we can merge this PR once CI passes. Thanks a lot for working on this! |
|
@tomhoule I've fixed it.
I don't care of build time. Many people dislike depending of skeptic at production build. |
|
Yes it's a good point. It would be nice to get rid of the dependency, but having the readme tested is very useful. Maybe we can do something with rustdoc directly, we should investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See budziq/rust-skeptic#60
I tried to use https://github.com/assert-rs/docmatic.
But we can't use that, because we use monorepo.