Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit tool to repository, and run on all files #730

Merged

Conversation

dan98765
Copy link
Contributor

Add pre-commit https://pre-commit.com/ and a config with a minimal set of hooks. Run on all files with tox -e pre-commit (also gets run as part of tox). I added a couple pep8 rules to the ignore list that were causing some not-pretty formatting and I didn't want to do any manual restyles as part of this PR. That said, I'm happy to change the config or ignored rules however the maintainers prefer.

Similar PR for graphql-core: graphql-python/graphql-core#178

@syrusakbary
Copy link
Member

Thanks for the PR @dan98765!
Merging :)

@syrusakbary syrusakbary merged commit 4720f77 into graphql-python:master May 25, 2018
@dan98765
Copy link
Contributor Author

Thanks @syrusakbary!
graphql-python/graphql-core#178 is the exact same change but for graphql-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants