chore: Use typing.TYPE_CHECKING
instead of MYPY
#1503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello graphene!
I found that the code base is using
MYPY
as a constant to tell whether a type checker is running.According to the mypy docs, however,
mypy
introduces a more commonly used constant:typing.TYPE_CHECKING
. So I'd like to suggest using this rather thanMYPY
.As
typing.TYPE_CHECKING
has been added since Python 3.5.2 andgraphene
supports from Python 3.6, there would be no problem with backporting.Reference: