Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify execution order in middleware docs #1475

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

rgroothuijsen
Copy link
Contributor

This PR adds a note to the middleware documentation noting the last-to-first execution order for middlewares, since #1385 indicates that some people were surprised by this behavior.

Fixes #1385

Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@erikwrede erikwrede merged commit b349632 into graphql-python:master Nov 15, 2022
@ahter
Copy link

ahter commented Dec 15, 2022

Is there specific reason why that these execute bottom-up, unlike other middleware?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention the order in which middlewares are executed in the docs
3 participants