Add copy function for GrapheneGraphQLType #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes graphql-python#1333 First found when using with a Django project. Django's tries to create a copy of a GrapheneGraphQLType and raises this KeyError
Codecov ReportBase: 95.88% // Head: 95.87% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1463 +/- ##
==========================================
- Coverage 95.88% 95.87% -0.01%
==========================================
Files 51 50 -1
Lines 1726 1722 -4
==========================================
- Hits 1655 1651 -4
Misses 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Sorry for the long wait, thank you for the PR! |
sg. thanks! |
erikwrede
approved these changes
Oct 24, 2022
|
Thank you for the contribution 🙂. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1333
First found in a Django project while upgrading to graphene 3. Django's
setUpTestDatatries to create a copy of a GrapheneGraphQLType and raises aKeyError: 'graphene_type'. This doesn't happen in graphene 2.1.8