hashable Enum #1461
Merged
hashable Enum #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikwrede
requested changes
Oct 23, 2022
| RED = 1 | ||
| GREEN = 2 | ||
| BLUE = 3 | ||
|
|
There was a problem hiding this comment.
This should also include the instance-creation pattern for enums, to ensure completeness:
https://docs.graphene-python.org/en/latest/types/enums/#definition
Episode = graphene.Enum('Episode', [('NEWHOPE', 4), ('EMPIRE', 5), ('JEDI', 6)])There was a problem hiding this comment.
Thanks! I added a test in my amended commit.
Codecov ReportBase: 95.87% // Head: 95.88% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1461 +/- ##
=======================================
Coverage 95.87% 95.88%
=======================================
Files 50 50
Lines 1722 1724 +2
=======================================
+ Hits 1651 1653 +2
Misses 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
erikwrede
approved these changes
Oct 27, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be convenient for
graphene.Enumto be hashable the same wayenum.Enumis so that it can be used as a key in a dict or a member of a set.