Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to provide a type name to enum when using from_enum #1430

Merged
merged 1 commit into from
Jun 27, 2022
Merged

feat: add ability to provide a type name to enum when using from_enum #1430

merged 1 commit into from
Jun 27, 2022

Conversation

tcleonard
Copy link
Collaborator

No description provided.

@tcleonard tcleonard force-pushed the feat/enable-to-provide-enum-name branch from aad8405 to 8f6a8f9 Compare June 24, 2022 16:18
@tcleonard tcleonard requested a review from erikwrede June 24, 2022 16:19
erikwrede
erikwrede approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Next step should be to add some central registry to check for naming collisions and invariant collisions. See #1418

@tcleonard tcleonard merged commit 72c2fd5 into graphql-python:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwrede erikwrede erikwrede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcleonard @erikwrede