feat: Add support for custom global ID type(Issue #1276) #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an updated version of #1278 |
|
@ulgens Do you have time for a review? |
ulgens
previously approved these changes
Aug 28, 2022
tcleonard
force-pushed
the
issue-#1276_allow_other_identifiers
branch
from
4a057f2 to
9509841
Compare
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
==========================================
+ Coverage 95.72% 95.88% +0.16%
==========================================
Files 50 51 +1
Lines 1683 1726 +43
==========================================
+ Hits 1611 1655 +44
+ Misses 72 71 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tcleonard
force-pushed
the
issue-#1276_allow_other_identifiers
branch
from
41293eb to
d1f6412
Compare
|
@ulgens I have rebased on master and added a few tests to get full coverage. Do you mind double checking and approving so I can merge? |
erikwrede
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for issue #1276