-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix actions #1359
Fix actions #1359
Conversation
@jkimbo @syrusakbary what do you suggest we do with the pre-commit hooks? Should they alter files when we commit (this might be a large change because every file is checked). Right now, the PR checks fail if there is any issue with the commit (like improper formatting or old python code). |
I'm also having trouble running pre-commit on my machine. black formatter fails because of Errno 13, as well as pyupgrade for some reason. I will try to fix this later on another machine. |
Great work on the PR @codebyaryan. The action should just check if the lint is correct, but don't update the code automatically (that should be done on the user side before pushing). Once that's done we should be good to merge! |
Thanks for the reply! I will make this PR ready ASAP! |
shouldn't the |
Just fixed it! |
@syrusakbary I know it's too late but it would be nicer if we squashed this before merging 🙂 |
With the previous PR where we aimed to fix CI with github actions, the workflows had a few problems. This PR aims to fix that.
What's been added/modified:
Also, python 3.8 is being primarily used, because it's the most stable version we have yet (over 3.9)
Also removes unused imports from test files.