Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a Type Warning as per #1100 #1282

Closed
wants to merge 1 commit into from

Conversation

evank28
Copy link

@evank28 evank28 commented Nov 14, 2020

Fixing a Type Warning that resolves #1100 for PyCharm IDE users.

Fixing a Type Warning that resolves graphql-python#1100 for PyCharm IDE users.
@skewty
Copy link

skewty commented Nov 27, 2020

should it be Optional[Type[ObjectType]]? None seems to be an acceptable value.

@erikwrede
Copy link
Member

We should fix all type hints and switch to this:
https://github.com/tox-dev/sphinx-autodoc-typehints

@skewty is right, Query should be optional. See types/schema.py:107 and graphql-core/type/schema.py:95. Closing this, as single-line type hint corrections don't solve the overall problem. PRs should be at least on a per-file basis to ensure we are not skimming through every file twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyCharm warning: Expected type 'ObjectType', got 'Type[Query]' instead
3 participants