-
Notifications
You must be signed in to change notification settings - Fork 824
Add UnforgivingExecutionContext #1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UnforgivingExecutionContext #1255
Conversation
@jkimbo I don't think I have access to request a review. What's the process from here? |
@jkimbo @syrusakbary I've updated this PR with fixes for an issue I found when using this in a different project. What are the next steps for either accepting or rejecting this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the interface and the results.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @AlecRosenbaum . This looks great thanks!
Released as v3.0.0b6 |
@AlecRosenbaum any docs for how to use this? |
No docs yet but I pulled this from the unit tests:
|
Sorry @coler-j, I meant to respond to this but got distracted. The unit test example above is probably the best example of how to use it. In the project I use this, we do some other custom stuff that wouldn't show the usage very well. |
This no longer works with graphene 3.1.5 as |
Resolves: #902
I'm not sure what the best place to add this execution context is. I'm happy to change naming and where this is defined to whatever is most appropriate.
Assuming this approach looks good, this probably also warrants some updates to the docs before merging.
Note that I have not added this as the default execution context since that would be a pretty breaking change. If a breaking change is ok, I'll update this PR.
In the project where I've taken a similar approach, I also added an
assert graphl.version == '3.1.1'
as a reminder to check the underlying implementation for changes when bumping versions. It might be worth adding a similar check here as well