Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed import causing Graphene v3 to crash #1143

Merged
merged 2 commits into from
Feb 26, 2020
Merged

Fixed import causing Graphene v3 to crash #1143

merged 2 commits into from
Feb 26, 2020

Conversation

jaydenwindle
Copy link
Contributor

This PR fixes #1142 by importing INVALID from graphql instead of graphql.errors in graphene/types/datetime.py.

@Cito
Copy link
Member

Cito commented Feb 26, 2020

Thanks for the fix. Since you're at it already, you should also change this to use Undefined instead of INVALID which has been deprecated.

@jaydenwindle
Copy link
Contributor Author

@Cito Good call, will do :)

@Cito Cito merged commit ac98be7 into graphql-python:master Feb 26, 2020
@jkimbo jkimbo mentioned this pull request Feb 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan98765 dan98765 Awaiting requested review from dan98765

@ekampf ekampf Awaiting requested review from ekampf

@jkimbo jkimbo Awaiting requested review from jkimbo

@ProjectCheshire ProjectCheshire Awaiting requested review from ProjectCheshire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graphene v3 crashes on import
2 participants
@jaydenwindle @Cito