feat: allow implementing interfaces in extendType #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #774 +/- ##
==========================================
+ Coverage 93.78% 93.84% +0.05%
==========================================
Files 46 46
Lines 2930 2926 -4
Branches 694 693 -1
==========================================
- Hits 2748 2746 -2
+ Misses 180 178 -2
Partials 2 2 |
izumin5210
commented
Jan 6, 2021
Comment on lines
-909
to
-914
| const toExtend = this.typeExtendMap[config.name] | ||
| if (toExtend) { | ||
| toExtend.forEach((e) => { | ||
| e.definition(definitionBlock) | ||
| }) | ||
| } |
There was a problem hiding this comment.
currently, we cannot extend interface types, so it's safe(no breaking) to remove these codes
https://codesandbox.io/s/extendtype-and-interface-ysf1v?file=/src/schema/index.ts
tgriesser
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #773
Allow implementing interfaces in
extendTypedefinition