Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add descriptions for input parameters if they exist (Complement #164) #167

Closed
dpalmmna opened this issue Dec 16, 2022 · 2 comments
Closed

Add descriptions for input parameters if they exist (Complement #164) #167

dpalmmna opened this issue Dec 16, 2022 · 2 comments

Comments

@dpalmmna
Copy link
Contributor

After correction of #164 the descriptions for input parameters are not used.

Proposed to add the descriptions if they exist.

Joined proposed code modifications to add these descriptions.

graphql-maven-plugin-logic\src\main\java\com\graphql_java_generator\plugin\DocumentParser.java
graphql-maven-plugin-logic\src\main\resources\templates\client_query_mutation_executor.vm.java
graphql-maven-plugin-logic\src\main\resources\templates\client_subscription_executor.vm.java
proposed-modifications.zip
@etienne-sf
Copy link
Collaborator

I'll check that.
If you've done the code modification, can you do a Pull Request on github for that ?
It would be easier for me to check the changes.

Etienne

dpalmmna added a commit to dpalmmna/graphql-maven-plugin-project that referenced this issue Jan 23, 2023
@dpalmmna
graphql-java-generator#167 Add descriptinos for input parameters if t…
4030b5c 
…hey exist
etienne-sf pushed a commit that referenced this issue Jan 24, 2023
@dpalmmna @etienne-sf
#167 Add descriptinos for input parameters if they exist
adfb1b8
etienne-sf pushed a commit that referenced this issue Jan 25, 2023
Complement for PR #167 (compilation issue)
d99a75c
@etienne-sf
Copy link
Collaborator

Released in the 1.18.10 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@etienne-sf @dpalmmna