Report lint issues inline, not on first char of file, for Vue and Svelte

[bmulholland]

Is it possible to resolve the limitations that results in the workaround introduced at #1346 ?

[bmulholland]

Amongst other things, I expect this limitation means that https://github.com/reviewdog/reviewdog (and similar, diff-based approaches) won't fail PRs that introduce linting errors, meaning we lost a critical enforcement of these policies.

[dimaMachina]

as I remember graphql-tag-pluck returns compiled code for vue/svelte files, as result - location of extracted documents will be incorrect from the source file

Maybe there is some workaround to parse vue/svelte files with vue/svelte parsers and run graphql-eslint processor on extracted js/ts code-blocks, example

  overrides: [
    {
      files: ['**/*.svelte'],
      parser: 'svelte-eslint-parser',
    },
    {
      files: ['**/*.svelte/*.{js,ts}'],
      processor: '@graphql-eslint/graphql',
    }
]

PR welcome

[bmulholland]

Oh interesting, yeah that limitation makes sense. Thanks for the detail, I appreciate it. I suspect the strings are often the same, so also a naive string match could work to correct the locations?

I don't quite understand how the workaround with parsers would maintain location information. Why wouldn't that have the same limitation?

[bmulholland]

Just to jot down an idea I had here: pluck could add a magic comment at the top of its output, which includes the location it was extracted from. Then this could be read and added as an offset when reporting the lint.

[bmulholland]

Ran out of time today, will check this on Vue files tomorrow.

[dimaMachina]

Good, thank you!

[bmulholland]

It just works! I have a pretty complex eslint config, too. Super cool :)

I did a few checks for additional things to note, but you've covered everything in that Vue example config. Nice work!

I can update the Vue docs with the latest -- is this approach stable? If not, I'll wait to document the final state.

[dimaMachina]

Thank you for your feedback! I would be appreciated in your new docs guide update 🙏