Skip to content

naming-convention rule FieldDefinition.ignorePattern config still checking underscores _ #1719

@DanielEscorciaOrtiz

Description

@DanielEscorciaOrtiz

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

  • 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

    For example, you can start off by editng the
    'basic' example on Stackblitz.

    Please make sure the graphql-eslint version under package.json matches yours.

  • 2. A failing test has been provided

  • 3. A local solution has been provided

  • 4. A pull request is pending review


Describe the bug

To Reproduce

With a schema like this:

# src/schema.graphql

type SomeType {
  _someField_: Boolean!
}

type Query {
  someType: SomeType
}

type Mutation {
  mutType: SomeType
}

And a .eslintrc like this:

module.exports = {
   [...]
    parserOptions: {
        schema: "src/schema.graphql"
    },
    rules: {
        '@graphql-eslint/naming-convention': [
            'error', {
                'FieldDefinition[parent.name.value=SomeType]': {
                    ignorePattern: ".*someField.*"
                }
            }
        ],
    }
}

I'm still receiving this errors:

<dir>/src/schema.graphql
  4:3  error  Leading underscores are not allowed   @graphql-eslint/naming-convention
  4:3  error  Trailing underscores are not allowed  @graphql-eslint/naming-convention

Expected behavior

It should ignore underscores if it matches the pattern, as described in the docs

Environment:

  • OS: macOs Ventura 13.4.1
  • @graphql-eslint/eslint-plugin: 3.19.1
  • Node.js: v18.16.0

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions