Skip to content

Conversation

@theguild-bot
Copy link
Collaborator

The examples converted from E2E tests have changed in 917307e.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Upgraded a key dependency to the latest version across multiple example projects.
    • In select cases, updated additional dependencies to their newer versions to leverage improvements and fixes.

Walkthrough

This pull request updates dependency versions in multiple example projects. In 15 package.json files, the @graphql-hive/gateway version is updated from ^1.9.4 to ^1.10.0. Additionally, two package.json files receive further modifications: one updates @graphql-mesh/transport-ws from ^1.0.2 to ^1.0.3 and another updates @graphql-mesh/hmac-upstream-signature from ^1.2.19 to ^1.2.20. No other changes were made.

Changes

File(s) Change Summary
examples/{apq-subgraphs, extra-fields, federation-example, federation-mixed, file-upload, interface-additional-resolvers, json-schema-subscriptions, openapi-additional-resolvers, openapi-arg-rename, openapi-javascript-wiki, openapi-subscriptions, operation-field-permissions, programmatic-batching, subscriptions-with-transforms, type-merging-batching}/package.json Updated @graphql-hive/gateway from ^1.9.4 to ^1.10.0
examples/federation-subscriptions-passthrough/package.json Updated @graphql-hive/gateway from ^1.9.4 to ^1.10.0 and @graphql-mesh/transport-ws from ^1.0.2 to ^1.0.3
examples/hmac-auth-https/package.json Updated @graphql-hive/gateway from ^1.9.4 to ^1.10.0 and @graphql-mesh/hmac-upstream-signature from ^1.2.19 to ^1.2.20

Possibly related PRs

  • Update Examples #604: Involves similar updates to the @graphql-hive/gateway dependency in package.json files with a different version increment.
  • Upcoming Release Changes #585: Directly addresses the dependency version update in package.json files, aligning closely with these modifications.
  • Upcoming Release Changes #583: Contains comparable dependency updates to @graphql-hive/gateway, reflecting a similar code-level change.

Poem

I'm a coding rabbit, hopping through the code,
Each package.json skipped a beat on a new version mode.
With ^1.10.0 in place, dependencies now align,
Extra tweaks in a few files mark the upgrade sign.
I hop with joy and nibble bytes all day,
Celebrating these changes in a bunny, whimsical way!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 917307e and 253ab84.

⛔ Files ignored due to path filters (34)
  • examples/apq-subgraphs/example.tar.gz is excluded by !**/*.gz
  • examples/apq-subgraphs/package-lock.json is excluded by !**/package-lock.json
  • examples/extra-fields/example.tar.gz is excluded by !**/*.gz
  • examples/extra-fields/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-example/example.tar.gz is excluded by !**/*.gz
  • examples/federation-example/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-mixed/example.tar.gz is excluded by !**/*.gz
  • examples/federation-mixed/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-subscriptions-passthrough/example.tar.gz is excluded by !**/*.gz
  • examples/federation-subscriptions-passthrough/package-lock.json is excluded by !**/package-lock.json
  • examples/file-upload/example.tar.gz is excluded by !**/*.gz
  • examples/file-upload/package-lock.json is excluded by !**/package-lock.json
  • examples/hmac-auth-https/example.tar.gz is excluded by !**/*.gz
  • examples/hmac-auth-https/package-lock.json is excluded by !**/package-lock.json
  • examples/interface-additional-resolvers/example.tar.gz is excluded by !**/*.gz
  • examples/interface-additional-resolvers/package-lock.json is excluded by !**/package-lock.json
  • examples/json-schema-subscriptions/example.tar.gz is excluded by !**/*.gz
  • examples/json-schema-subscriptions/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-additional-resolvers/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-additional-resolvers/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-arg-rename/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-arg-rename/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-javascript-wiki/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-javascript-wiki/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-subscriptions/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-subscriptions/package-lock.json is excluded by !**/package-lock.json
  • examples/operation-field-permissions/example.tar.gz is excluded by !**/*.gz
  • examples/operation-field-permissions/package-lock.json is excluded by !**/package-lock.json
  • examples/programmatic-batching/example.tar.gz is excluded by !**/*.gz
  • examples/programmatic-batching/package-lock.json is excluded by !**/package-lock.json
  • examples/subscriptions-with-transforms/example.tar.gz is excluded by !**/*.gz
  • examples/subscriptions-with-transforms/package-lock.json is excluded by !**/package-lock.json
  • examples/type-merging-batching/example.tar.gz is excluded by !**/*.gz
  • examples/type-merging-batching/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (17)
  • examples/apq-subgraphs/package.json (1 hunks)
  • examples/extra-fields/package.json (1 hunks)
  • examples/federation-example/package.json (1 hunks)
  • examples/federation-mixed/package.json (1 hunks)
  • examples/federation-subscriptions-passthrough/package.json (2 hunks)
  • examples/file-upload/package.json (1 hunks)
  • examples/hmac-auth-https/package.json (1 hunks)
  • examples/interface-additional-resolvers/package.json (1 hunks)
  • examples/json-schema-subscriptions/package.json (1 hunks)
  • examples/openapi-additional-resolvers/package.json (1 hunks)
  • examples/openapi-arg-rename/package.json (1 hunks)
  • examples/openapi-javascript-wiki/package.json (1 hunks)
  • examples/openapi-subscriptions/package.json (1 hunks)
  • examples/operation-field-permissions/package.json (1 hunks)
  • examples/programmatic-batching/package.json (1 hunks)
  • examples/subscriptions-with-transforms/package.json (1 hunks)
  • examples/type-merging-batching/package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
`examples/**`: In this directory we keep all the examples. E...

examples/**: In this directory we keep all the examples. Examples are generated using a scheduled CI pipeline.
When changes are made to Gateway config, we expect to see some changes in the examples directory.

  • examples/openapi-subscriptions/package.json
  • examples/interface-additional-resolvers/package.json
  • examples/openapi-arg-rename/package.json
  • examples/extra-fields/package.json
  • examples/openapi-javascript-wiki/package.json
  • examples/openapi-additional-resolvers/package.json
  • examples/federation-example/package.json
  • examples/operation-field-permissions/package.json
  • examples/apq-subgraphs/package.json
  • examples/programmatic-batching/package.json
  • examples/subscriptions-with-transforms/package.json
  • examples/federation-mixed/package.json
  • examples/type-merging-batching/package.json
  • examples/json-schema-subscriptions/package.json
  • examples/file-upload/package.json
  • examples/hmac-auth-https/package.json
  • examples/federation-subscriptions-passthrough/package.json
`**`: For all PRs, we would like to verify that a Linear iss...

**: For all PRs, we would like to verify that a Linear issue is linked. Check if there's a mention for "GW-*" in the PR description, and the us know when it's missing.

In most cases, when a PR adds a new functionality, we would like to make sure it has documentation in the corresponding console project.
Use the global knowledge feature to search for PRs in graphql-hive/console repository that adds documentation. Suggest to create a follow up issue to add the missing documentation.

  • examples/openapi-subscriptions/package.json
  • examples/interface-additional-resolvers/package.json
  • examples/openapi-arg-rename/package.json
  • examples/extra-fields/package.json
  • examples/openapi-javascript-wiki/package.json
  • examples/openapi-additional-resolvers/package.json
  • examples/federation-example/package.json
  • examples/operation-field-permissions/package.json
  • examples/apq-subgraphs/package.json
  • examples/programmatic-batching/package.json
  • examples/subscriptions-with-transforms/package.json
  • examples/federation-mixed/package.json
  • examples/type-merging-batching/package.json
  • examples/json-schema-subscriptions/package.json
  • examples/file-upload/package.json
  • examples/hmac-auth-https/package.json
  • examples/federation-subscriptions-passthrough/package.json
⏰ Context from checks skipped due to timeout of 90000ms (26)
  • GitHub Check: Unit / Node v23
  • GitHub Check: Unit / Bun
  • GitHub Check: E2E / Bun Docker on Ubuntu
  • GitHub Check: Unit / Node v22
  • GitHub Check: E2E / Bun on Ubuntu
  • GitHub Check: Leaks / Node v23
  • GitHub Check: Leaks / Node v22
  • GitHub Check: E2E / Node Binary on Windows
  • GitHub Check: Unit / Node v18
  • GitHub Check: E2E / Node Binary on Ubuntu
  • GitHub Check: Leaks / Node v20
  • GitHub Check: Benchmark / bun / 1000 items
  • GitHub Check: E2E / Node Docker on Ubuntu
  • GitHub Check: Benchmark / bun / 100 items
  • GitHub Check: E2E / Node 23 on Ubuntu
  • GitHub Check: Benchmark / bun / 10 items
  • GitHub Check: Leaks / Node v18
  • GitHub Check: E2E / Node 22 on Ubuntu
  • GitHub Check: Benchmark / node / 1000 items
  • GitHub Check: Build
  • GitHub Check: E2E / Node 20 on Ubuntu
  • GitHub Check: Benchmark / node / 100 items
  • GitHub Check: Bundle
  • GitHub Check: E2E / Node 18 on Ubuntu
  • GitHub Check: Benchmark / node / 10 items
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (19)
examples/openapi-javascript-wiki/package.json (1)

10-10: LGTM!

The dependency version update follows semantic versioning.

examples/openapi-additional-resolvers/package.json (1)

10-10: Dependency version update looks good.

examples/file-upload/package.json (1)

8-8: Dependency version update looks good.

examples/apq-subgraphs/package.json (1)

12-12: Dependency version update looks good.

examples/interface-additional-resolvers/package.json (1)

9-9: Dependency version update looks good.

examples/programmatic-batching/package.json (1)

10-10: LGTM! Dependency version bump looks good.

The update of @graphql-hive/gateway from ^1.9.4 to ^1.10.0 is consistent across all example projects.

examples/openapi-arg-rename/package.json (1)

10-10: LGTM! Dependency version bump looks good.

The update of @graphql-hive/gateway from ^1.9.4 to ^1.10.0 is consistent across all example projects.

examples/extra-fields/package.json (1)

9-9: LGTM! Dependency version bump looks good.

The update of @graphql-hive/gateway from ^1.9.4 to ^1.10.0 is consistent across all example projects.

examples/operation-field-permissions/package.json (1)

9-9: LGTM! Dependency version bump looks good.

The update of @graphql-hive/gateway from ^1.9.4 to ^1.10.0 is consistent across all example projects.

examples/type-merging-batching/package.json (2)

9-9: LGTM! Dependency version bump looks good.

The update of @graphql-hive/gateway from ^1.9.4 to ^1.10.0 is consistent across all example projects.


1-23:

❓ Verification inconclusive

Missing Linear issue reference.

According to the coding guidelines, all PRs should have a Linear issue (GW-*) linked in the PR description. Please add the corresponding Linear issue reference.

Verify if documentation updates are needed.

Since this is a version bump, please verify if there are any new features or breaking changes that require documentation updates in the console project.


🌐 Web query:

What's new in @graphql-hive/gateway version 1.10.0?

💡 Result:

The provided search results do not contain specific information about @graphql-hive/gateway v1.10.0. However, here are details about recent versions and features based on available sources:


Latest Updates (as of February 2025)

v1.9.x Releases (Source):

  • Native AbortSignal/AbortController support (v1.9.4):
    • Removed custom abort signal implementation in favor of native APIs.
  • WebSocket transport improvements (v1.9.x):
    • Upgraded graphql-ws to v6 with simplified configuration.
  • Custom cache factory support (v1.9.0):
    • Added programmatic cache configuration via cache: (ctx) => KeyValueCache.

Key Features of Hive Gateway (Source):

  • Acts as a Federation Gateway or Proxy Gateway.
  • Supports:
    • Subscription protocols (WebSockets/SSE/HTTP callbacks).
    • Role-based access control (@authenticated, @requiresScope).
    • Redis-based distributed caching.
    • OpenTelemetry/Prometheus integration.

Missing v1.10.x Details

The search results do not include specifics for v1.10.0. For official release notes, check:

Citations:


Action Required: Add Missing Linear Issue Reference and Review Documentation

  • Linear Issue Reference: The PR description is missing a required Linear issue (GW-*) reference. Please update the PR description to include the appropriate issue ID according to our coding guidelines.
  • Documentation Check: This PR bumps the version of @graphql-hive/gateway to 1.10.0. While the available information does not show specific breaking changes or new features for this version, please verify the official release notes to determine if any documentation updates in the console project are needed.
examples/subscriptions-with-transforms/package.json (1)

10-10: LGTM: Version update to @graphql-hive/gateway ^1.10.0

The dependency version update is consistent with other example projects.

examples/openapi-subscriptions/package.json (1)

12-12: LGTM: Version update to @graphql-hive/gateway ^1.10.0

The dependency version update is consistent with other example projects.

examples/json-schema-subscriptions/package.json (1)

13-13: LGTM: Version update to @graphql-hive/gateway ^1.10.0

The dependency version update is consistent with other example projects.

examples/federation-example/package.json (1)

12-12: LGTM: Version update to @graphql-hive/gateway ^1.10.0

The dependency version update is consistent with other example projects.

examples/federation-mixed/package.json (2)

12-12: LGTM: Version update to @graphql-hive/gateway ^1.10.0

The dependency version update is consistent with other example projects.


1-29:

❓ Verification inconclusive

Missing Linear issue reference

According to the coding guidelines, we need to verify that a Linear issue is linked. Please add a reference to the corresponding "GW-*" issue in the PR description.

Check if documentation update is needed

Since this is a version update (1.9.4 -> 1.10.0), please verify if any documentation updates are needed in the graphql-hive/console repository.

Let me check for related documentation PRs:


🏁 Script executed:

#!/bin/bash
# Search for recent PRs in graphql-hive/console repository that might contain documentation updates
gh pr list --repo graphql-hive/console --search "gateway 1.10.0 in:title,body" --state all --limit 5

Length of output: 102


Action Required: Ensure PR Description and Documentation Are Up-to-Date

  • Linear Issue Reference: Please update the PR description with the corresponding "GW-*" Linear issue reference as required by our coding guidelines.
  • Documentation Verification: Although the automated search for related documentation PRs in the graphql-hive/console repository for version 1.10.0 did not return any results, please manually review if any documentation updates are needed due to the version bump (1.9.4 → 1.10.0).
examples/federation-subscriptions-passthrough/package.json (1)

5-5: LGTM! Minor version updates for dependencies.

The dependency updates look good:

  • @graphql-mesh/transport-ws: ^1.0.2 -> ^1.0.3
  • @graphql-hive/gateway: ^1.9.4 -> ^1.10.0

Also applies to: 18-18

examples/hmac-auth-https/package.json (1)

15-15: LGTM! Minor version updates for dependencies.

The dependency updates look good:

  • @graphql-hive/gateway: ^1.9.4 -> ^1.10.0
  • @graphql-mesh/hmac-upstream-signature: ^1.2.19 -> ^1.2.20

Also applies to: 17-17


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ardatan ardatan merged commit 3a3cd30 into main Feb 13, 2025
42 of 43 checks passed
@ardatan ardatan deleted the examples/update branch February 13, 2025 13:13
This was referenced Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants