-
Notifications
You must be signed in to change notification settings - Fork 25
Expose the query plan in graphql extensions for Rust QP #1739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @enisdenjo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a new capability to include the GraphQL query plan directly within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a feature to expose the query plan in GraphQL extensions, which is useful for debugging. The implementation for standard queries is correct, and it's accompanied by a good test case. I've provided a suggestion to improve the implementation to handle streaming responses (like subscriptions) and to make adding extensions more robust by merging with existing ones. I've also recommended adding a test case for subscriptions to ensure complete coverage of the new feature.
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-tools/batch-delegate |
10.0.6-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/delegate |
12.0.0-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/federation |
4.2.4-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/fusion-runtime |
1.6.0-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway |
2.1.20-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/nestjs |
2.0.25-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/plugin-aws-sigv4 |
2.0.18-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/plugin-opentelemetry |
1.2.2-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-prometheus |
2.1.6-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/router-runtime |
1.1.0-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway-runtime |
2.3.6-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/stitch |
10.1.4-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/stitching-directives |
4.0.6-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway-testing |
2.0.6-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/wrap |
11.1.0-alpha-8ea56a824441049703364ec2185ae13fb31495bb |
npm ↗︎ unpkg ↗︎ |
🚀 Snapshot Release (Bun Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared |
🚀 Snapshot Release (Node Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared |
Ref GW-531, ref GW-532
results in
{ "data": { "hello": "world", }, "extensions": { "queryPlan": { "kind": "QueryPlan", "node": { "kind": "Fetch", "operation": "{hello}", "operationKind": "query", "serviceName": "upstream", }, }, }, }TODO