Skip to content

Correctly handle nested fragment spreads on interface fields #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 28, 2025
+7 −2
Merged

Correctly handle nested fragment spreads on interface fields #1735

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0a762a9
organize test
enisdenjo Nov 26, 2025
9be6418
ok fix
enisdenjo Nov 26, 2025
1d80291
not actually testing what's necessary
enisdenjo Nov 26, 2025
6fa49dc
Revert "ok fix"
enisdenjo Nov 26, 2025
a5e9ca8
changeset
enisdenjo Nov 26, 2025
986163d
Reapply "ok fix"
enisdenjo Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/stitch/src/subschemaConfigTransforms/isolateComputedFieldsTransformer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ function filterBaseSubschema(
}
}
const allTypes = [typeName, ...iFacesForType];
const isIsolatedFieldName = allTypes.every((implementingTypeName) =>
const isIsolatedFieldName = allTypes.some((implementingTypeName) =>
isIsolatedField(implementingTypeName, fieldName, isolatedSchemaTypes),
);
Copy link

@gemini-code-assist gemini-code-assist bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This logic change from every to some is crucial for correctly identifying isolated fields across type hierarchies. As noted in the PR description, this change is not currently covered by tests. Please add tests to verify this new behavior and prevent future regressions, especially for cases involving nested fragments and interfaces.

const isKeyFieldName = allTypes.some((implementingTypeName) =>
Expand Down Expand Up @@ -357,7 +357,7 @@ function filterBaseSubschema(
...iFacesForType,
...typesForInterface[typeName],
];
const isIsolatedFieldName = allTypes.every((implementingTypeName) =>
const isIsolatedFieldName = allTypes.some((implementingTypeName) =>
isIsolatedField(implementingTypeName, fieldName, isolatedSchemaTypes),
);
Copy link

@gemini-code-assist gemini-code-assist bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Similar to the objectFieldFilter, this logic change from every to some is crucial. It's important to add tests that validate this new filtering logic for interface fields to ensure correctness and prevent regressions.

const isKeyFieldName = allTypes.some((implementingTypeName) =>
Expand Down
Loading