fix(rate-limiter): incorrectly applying to non-configured fields#2690
Merged
EmrysMyrddin merged 4 commits intographql-hive:mainfrom Sep 19, 2025
Merged
fix(rate-limiter): incorrectly applying to non-configured fields#2690EmrysMyrddin merged 4 commits intographql-hive:mainfrom
EmrysMyrddin merged 4 commits intographql-hive:mainfrom
Conversation
Contributor
|
Great catch! Thank you very much for the fix! I took the freedom to push a changeset to your branch so that I can release as quickly as possible. |
EmrysMyrddin
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug where the rate limiter plugin was incorrectly applying rate limiting to GraphQL fields not configured in
configByField. Fields that should be unlimited were getting rate limited with default error messages.The root cause was that
{ ...(rateLimitDirective ?? fieldConfig) }creates an empty object{}when both values are undefined, which is truthy, causing rate limiting to be applied to all fields.Fixes #2689
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
N/A - This is a backend logic fix with test coverage.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
'should not rate limit fields that are not in configByField'Test Environment:
@envelop/rate-limiter: 8.1.0Checklist: