fix(withState): respect getters and setters of non hook properties #2665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@envelop/core |
5.3.2-alpha-20250915143539-fd5e49440b71c59031c3455714d9baf604d1ae63 |
npm ↗︎ unpkg ↗︎ |
@envelop/parser-cache |
9.0.1-alpha-20250915143539-fd5e49440b71c59031c3455714d9baf604d1ae63 |
npm ↗︎ unpkg ↗︎ |
@envelop/rate-limiter |
8.1.0-alpha-20250915143539-fd5e49440b71c59031c3455714d9baf604d1ae63 |
npm ↗︎ unpkg ↗︎ |
@envelop/response-cache |
8.0.2-alpha-20250915143539-fd5e49440b71c59031c3455714d9baf604d1ae63 |
npm ↗︎ unpkg ↗︎ |
@envelop/validation-cache |
9.0.1-alpha-20250915143539-fd5e49440b71c59031c3455714d9baf604d1ae63 |
npm ↗︎ unpkg ↗︎ |
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://87091d71.envelop.pages.dev |
enisdenjo
approved these changes
Aug 18, 2025
ardatan
requested changes
Aug 18, 2025
Member
ardatan
left a comment
ardatan
left a comment
There was a problem hiding this comment.
Do you think failing tests are related?
Collaborator
Author
|
Weird, no I don't see how it could be linked :/ the test doesn't even use |
EmrysMyrddin
force-pushed
the
fix/respect-getters-setters
branch
from
fce0176 to
fd5e494
Compare
Collaborator
Author
|
@ardatan Test are passing again after a rebase :-) |
ardatan
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
withStateplugin utility was not respecting plugin properties with getters or setters.In particular, properties with getters were just copied at plugin creating time, leading to potential bugs where the getter doesn't always return the same thing over time.
This PR fixes this by enumerating all properties with
Object.getOwnPropertyDescriptorsand iterating over it instead ofObject.entries. This also allows to keep theenumerable,writableandconfigurableflags from each non-hooks properties.See this PR for a usage of this: graphql-hive/gateway#1360