Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quotation during printing StringValue node #587

Merged
merged 3 commits into from
Apr 11, 2021

Conversation

pkosiec
Copy link
Contributor

@pkosiec pkosiec commented Dec 8, 2020

Fixes #586.

See the details of the bug in the linked issue.

@coveralls
Copy link

coveralls commented Jan 2, 2021

Coverage Status

Coverage remained the same at 92.422% when pulling 18f6ed0 on pkosiec:fix-json-string-arg into 1a9db88 on graphql-go:master.

@pkosiec
Copy link
Contributor Author

pkosiec commented Apr 7, 2021

Hi @chris-ramon, any news regarding this PR? Can you review it please? It's just 16 lines. Thanks!

Copy link
Member

@chris-ramon chris-ramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 –– Thanks a lot @pkosiec 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect quotation when printing StringValue node
3 participants