Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error detection #561

Merged
merged 2 commits into from
Aug 17, 2020
Merged

fix: error detection #561

merged 2 commits into from
Aug 17, 2020

Conversation

CxdInitial
Copy link
Contributor

should check nullability of gt.err instead of local variable err which was checked before

@coveralls
Copy link

coveralls commented Aug 3, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 92.426% when pulling 30eae24 on CxdInitial:patch-1 into 33f0862 on graphql-go:master.

chris-ramon
chris-ramon approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@chris-ramon chris-ramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 –– Nice catch! Thanks a lot @CxdInitial 💯 🚢

@chris-ramon chris-ramon merged commit d6b7434 into graphql-go:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-ramon chris-ramon chris-ramon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CxdInitial @coveralls @chris-ramon