Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use tapSubgraph to ignore connection with tapContracts #952

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix: use tapSubgraph to ignore connection with tapContracts #952

merged 2 commits into from
Jul 15, 2024

Conversation

carlosvdr
Copy link
Contributor

No description provided.

@carlosvdr carlosvdr added the TAP label Jul 12, 2024
@carlosvdr carlosvdr requested a review from fordN July 12, 2024 00:17
@carlosvdr carlosvdr self-assigned this Jul 12, 2024
@carlosvdr carlosvdr linked an issue Jul 12, 2024 that may be closed by this pull request
RAV processing still executing even if user doesn't configure TAP #951
Closed
@fordN
Copy link
Contributor

fordN commented Jul 12, 2024

Please use commit format we've been trying to stick to:

component name: Description

Further description if needed

So first commit message would be something like:

common: Use tapSubgraph config to control TAP/RAV feature

If a user does not config tapSubgraph, do not connect to TAP contracts or
execute RAV processing functions

@carlosvdr carlosvdr force-pushed the issue951 branch 2 times, most recently from bd41102 to 95f111f Compare July 12, 2024 18:23
@carlosvdr carlosvdr requested a review from fordN July 12, 2024 19:24
dwerner
dwerner approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@dwerner dwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@carlosvdr @dwerner
common: use tapSubgraph config to control TAP feature
9e7523c 
If a user doesnt set up the tapSubgraph config, features related to TAP will be disabled.
Such as connect to TAP contract or RAV processing.
@carlosvdr carlosvdr merged commit 7535832 into main Jul 15, 2024
10 checks passed
@carlosvdr carlosvdr deleted the issue951 branch July 15, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasseman aasseman aasseman left review comments

@dwerner dwerner dwerner approved these changes

@fordN fordN Awaiting requested review from fordN

Assignees

@carlosvdr carlosvdr

Labels
TAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RAV processing still executing even if user doesn't configure TAP
4 participants
@carlosvdr @fordN @dwerner @aasseman