Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indexer-cli: add type annotation for test util network specification #944

Merged
merged 1 commit into from
Jul 8, 2024
Merged

indexer-cli: add type annotation for test util network specification #944

merged 1 commit into from
Jul 8, 2024

Conversation

dwerner
Copy link
Contributor

@dwerner dwerner commented Jul 8, 2024

In release 0.23.1, some are encountering a type annotation issue building cli.

src/indexer-management/__tests__/util.ts(19,14): error TS2742: The inferred type of 'testNetworkSpecification' cannot be named without a reference to '@graphprotocol/indexer-cli/node_modules/ethers'. This is likely not portable. A type annotation is necessary.

@dwerner dwerner requested a review from fordN July 8, 2024 18:10
@dwerner dwerner merged commit d9d76db into main Jul 8, 2024
10 checks passed
@dwerner dwerner deleted the fixup/release-0.21.3 branch July 8, 2024 19:36
@dwerner dwerner mentioned this pull request Jul 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saihaj saihaj saihaj approved these changes

@fordN fordN Awaiting requested review from fordN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwerner @saihaj