indexer-common: Avoid using createdAt field for pagination

[fordN]

Changes

• Update several NetworkMonitor functions to paginate by id instead of by createdAt. Functions updated: subgraphs(), subgraphDeployments() and disputableAllocations().

Background

On L2 networks, like arbitrum-one, createdAt is not necessarily unique, so paginating based on createdAt can lead to missing items.

[dwerner]

lgtm! thanks

[aasseman]

Just nitpicking on adhering to the subgraph's schema, though graph-node may currently allow these things.

Also, somewhat unrelated, I found a few places in the code where pagination isn't implemented at all. In particular that could cause issues if somehow an indexer managed to open more than 1000 allocations. We know that some indexers are already indexing more than 1000 subgraphs at a time, so it's not completely impossible.

[dwerner]

Removing my approval as I've made changes now.

[aasseman]

One of the comments was not addressed. GitHub won't let me explicitly select the piece of code....

So here's the issue:
packages/indexer-common/src/indexer-management/monitor.ts:1139 $createdAt: Int! should be $lastId: ID!

[dwerner]

One of the comments was not addressed. GitHub won't let me explicitly select the piece of code....

So here's the issue: packages/indexer-common/src/indexer-management/monitor.ts:1139 $createdAt: Int! should be $lastId: ID!

Thanks for catching this.

[dwerner]

Looks good to me.