Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: Support setting rate limits and body size limits at startup #900

Merged
merged 1 commit into from
May 31, 2024
Merged

service: Support setting rate limits and body size limits at startup #900

merged 1 commit into from
May 31, 2024

Conversation

fordN
Copy link
Contributor

@fordN fordN commented May 29, 2024 •
edited
Loading

Changes

  • Added new startup parameters:
    • body-size-limit: Max body size per request (mb),
    • info-rate-limit: Max requests per minute before returning 429 status codes, applies to paths: /cost, /health, /operator,
    • status-rate-limit: Max requests per minute before returning 429 status codes, applies to paths: /status, /network

@fordN fordN self-assigned this May 29, 2024
@fordN fordN added indexer-service enhancement New feature or request labels May 29, 2024
dwerner
dwerner approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@dwerner dwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@fordN fordN force-pushed the ford/expose-server-options-as-startup-params branch from aeeb1d2 to d892b49 Compare May 31, 2024 16:16
@fordN
service: Expose server options as startup params
fbc026d 
- New startup parameters: 'body-size-limit', 'info-rate-limit',
'status-rate-limit'
@fordN fordN force-pushed the ford/expose-server-options-as-startup-params branch from d892b49 to fbc026d Compare May 31, 2024 17:13
@fordN fordN merged commit 8f10717 into main May 31, 2024
10 checks passed
@fordN fordN deleted the ford/expose-server-options-as-startup-params branch May 31, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwerner dwerner dwerner approved these changes

Assignees

@fordN fordN

Labels
enhancement New feature or request indexer-service
Projects
Indexer
Status: 🚗 Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fordN @dwerner