Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add rstest and fixtures #632

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

test: add rstest and fixtures #632

wants to merge 6 commits into from

Conversation

carlosvdr
Copy link
Collaborator

@carlosvdr carlosvdr commented Feb 14, 2025

Added rstest:

  • with this several tests have been refactored to only receive fixtures created on rstest

this PR aims to make the tests more easy reading and only focusing on the important bits per test

Due to the nature of async fixtures some tests could use them since the test itself needed to be in some order for it to work as intended.

@carlosvdr carlosvdr self-assigned this Feb 14, 2025
Copy link
Contributor

Pull Request Test Coverage Report for Build 13338777287

Details

  • 58 of 62 (93.55%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 75.527%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/tap-agent/src/agent/sender_accounts_manager.rs 7 9 77.78%
crates/test-assets/src/lib.rs 29 31 93.55%
Files with Coverage Reduction New Missed Lines %
crates/tap-agent/src/agent/sender_account.rs 1 75.63%
Totals Coverage Status
Change from base Build 13317981472: -0.3%
Covered Lines: 8237
Relevant Lines: 10906

💛 - Coveralls

@carlosvdr carlosvdr marked this pull request as ready for review February 14, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant