Subgraph Composition: Support ethereum host functions in dependant subgraphs #5704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
changed the base branch from
master
to
krishna/cache-firehose-blocks
incrypto32
force-pushed
the
krishna/sgc-eth-host-fns
branch
from
9988257 to
c54b98e
Compare
incrypto32
changed the base branch from
krishna/cache-firehose-blocks
to
krishna/switch-to-using-only-block-ptrs
incrypto32
changed the base branch from
krishna/switch-to-using-only-block-ptrs
to
krishna/sgc-use-firehose-get-block
mangas
approved these changes
Nov 22, 2024
incrypto32
force-pushed
the
krishna/sgc-eth-host-fns
branch
2 times, most recently
from
c54b98e to
1dd59c3
Compare
|
Would this work be re-usable to also enable Ethereum hosts fn on Substreams datasource? This was requested before and when I saw the PR, it felt it could be applied to Substreams data sources too. |
|
@maoueh it can be applied but what purpose does it serve? Substreams cannot call these host functions on the graph-node anyways (i believe). |
|
There is two Substreams integration now:
It's on the second case that it make sense to add it. People have been request it to be able to make |
|
@maoueh got it, yes i think it makes sense to add them and i believe there's not much additional work other than just adding them as host_fns. Feel free to open an issue. |
2 tasks
incrypto32
force-pushed
the
krishna/sgc-use-firehose-get-block
branch
from
f95df0a to
a1ed8b2
Compare
incrypto32
force-pushed
the
krishna/sgc-eth-host-fns
branch
from
1dd59c3 to
e0a65dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.