Subgraph composition : TriggersAdapter wrapper #5695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…datasource triggers
incrypto32
changed the title
incrypto32
commented
Nov 7, 2024
incrypto32
commented
Nov 7, 2024
incrypto32
commented
Nov 7, 2024
mangas
reviewed
Nov 11, 2024
mangas
reviewed
Nov 11, 2024
mangas
reviewed
Nov 11, 2024
mangas
reviewed
Nov 11, 2024
|
|
||
| impl UnresolvedDataSource { | ||
| #[allow(dead_code)] | ||
| pub(super) async fn resolve( |
There was a problem hiding this comment.
Does this need some test coverage?
There was a problem hiding this comment.
graph-node/store/test-store/tests/chain/ethereum/manifest.rs
Lines 202 to 203 in c7ca25a
There is little testing for resolving this UnresolvedDatasource. Would you suggest anything more?
|
Would be good to address some of the comments, particularly around docs and comments. I also didn't see much in the way of testing. Would be great to see some test coverage around the new paths. |
incrypto32
force-pushed
the
subgraph-composition-blockstream
branch
from
cd6114d to
9069486
Compare
|
Just addressed the comments, and the suggestion for not using the WriteStore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a wrapper around the TriggersAdapter to support subgraph triggers from other subgraphs. Previously, the TriggersAdapter was chain-specific, handling triggers only for individual chains. With subgraph data sources, we need a higher-level adapter to fetch entity triggers from source subgraphs without depending on any specific chain.
This PR lays the groundwork for enabling the new subgraph data source type. The changes include:
Allow subgraph datasource in manifest
A wrapper for TriggersAdapter
A wrapper for TriggerFilter
A new trigger type specific to subgraph data sources