-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sf/block stream future03 #2679
Merged
leoyvens
merged 12 commits into
graphprotocol:master
from
streamingfast:sf/block_stream_future03
Aug 11, 2021
Merged
Sf/block stream future03 #2679
leoyvens
merged 12 commits into
graphprotocol:master
from
streamingfast:sf/block_stream_future03
Aug 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jubeless
commented
Aug 2, 2021
- Attempt to upgrade tokio to 1.9 By doing so it would give us the flexibility to upgrade ethabi library as well as tokio-retry library.
- Modified blockstream implementation to support future 0.3
- Modified cancellable to support future 0.3
- Modified retry lib to support future 0.3. Now retry func expects a future 0.3 function
- Sprinkled some boxed & compat where needed
- Fixed examples
leoyvens
requested changes
Aug 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this out in hosted and it is working wonders, I have a few small comments, and then this is ready to merge after a rebase.
This was referenced Aug 6, 2021
Closed
jubeless
force-pushed
the
sf/block_stream_future03
branch
from
August 11, 2021 15:08
6b1907b
to
a9a53a5
Compare
@leoyvens Rebased and fixed the comments! lets get another workflow going |
This reverts commit a32d631. # Conflicts: # Cargo.lock # chain/ethereum/src/block_ingestor.rs # chain/ethereum/tests/network_indexer.rs # core/src/subgraph/instance_manager.rs # graph/Cargo.toml # graph/src/data/graphql/effort.rs # graph/src/util/futures.rs # graphql/src/execution/execution.rs # graphql/tests/query.rs # runtime/test/src/test/abi.rs # runtime/wasm/Cargo.toml # runtime/wasm/src/host_exports.rs # runtime/wasm/src/mapping.rs # runtime/wasm/src/module/test.rs # store/postgres/src/chain_head_listener.rs # store/postgres/tests/graft.rs # store/test-store/src/store.rs
- Modified blockstream implementation to support future 0.3 - Modified cancellable to support future 0.3 - Modified `retry` lib to support future 0.3. Now retry func expects a future 0.3 function - Sprinkled some `boxed` & `compat` where needed - Fixed exemples
jubeless
force-pushed
the
sf/block_stream_future03
branch
from
August 11, 2021 15:27
a9a53a5
to
ce8d71a
Compare
leoyvens
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.