Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies + add fix-pages-structure script and run it before build #838

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

benface
Copy link
Contributor

@benface benface commented Dec 14, 2024

This PR applies minor dependency updates, which notably refreshes the Supported Networks table, and it adds a fix-pages-structure script to improve the process of adding/removing/moving pages, considering our Crowdin setup. It ensures that any page or directory that was added or removed in English is also added or removed in other languages. The script runs on prebuild so it will run in CI/CD, preventing build errors in PRs that add or move pages, which has been a recurring source of frustration. I also ran it and committed the results directly in this PR; you can see that it removes a bunch of orphaned pages and adds some missing _meta.js files.

@benface benface requested a review from a team as a code owner December 14, 2024 03:58
@benface benface merged commit 00fe78c into main Dec 16, 2024
4 checks passed
@benface benface deleted the benface/fix-pages-structure branch December 16, 2024 16:03
@idalithb
Copy link
Contributor

@benface Terrific work! This is such an improvement 🥳

@benface benface mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants