Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move i18n module to components #75

Merged
merged 21 commits into from
Mar 3, 2022
Merged

Move i18n module to components #75

merged 21 commits into from
Mar 3, 2022

Conversation

benface
Copy link
Contributor

@benface benface commented Mar 3, 2022

No description provided.

@benface benface requested a review from a team as a code owner March 3, 2022 17:34
benface added 2 commits March 3, 2022 12:39
# Conflicts:
#	i18n/translations.ts
#	layout/Layout.tsx
#	layout/MDXLayoutOutline.tsx
#	layout/MDXLayoutPagination.tsx
#	package.json
#	pages/[locale]/index.tsx
#	yarn.lock
Copy link
Contributor

@IainM22 IainM22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link

@cmwhited cmwhited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without having much insight into the translations process, from what I can tell, this looks good. Nothing sticks out. Good work.

Copy link

@dnfodjo dnfodjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Great job

@benface benface merged commit 7050c64 into main Mar 3, 2022
@benface benface deleted the benface/i18n branch March 3, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants