Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick start edits #743

Merged
merged 19 commits into from
Sep 12, 2024
Merged

Quick start edits #743

merged 19 commits into from
Sep 12, 2024

Conversation

idalithb
Copy link
Contributor

-adding and edited content

@idalithb idalithb requested a review from a team as a code owner August 16, 2024 17:26
@github-actions GitHub Actions

This comment was marked as off-topic.

Sign in to view
saihaj
saihaj requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid just few comments

website/pages/en/quick-start.mdx Outdated Show resolved Hide resolved
website/pages/en/quick-start.mdx Outdated Show resolved Hide resolved
website/pages/en/quick-start.mdx Outdated
@@ -2,24 +2,20 @@
title: Quick Start
---

This guide will quickly take you through how to initialize, create, and deploy your subgraph to Subgraph Studio.
This guide walks you through the basics of creating, deploying, publishing, and querying a subgraph on The Graph easily.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering that if the word subgraph should link to some glossary which explains that a Subgraph is for the folks who are completely new this is their quick start tutorial and not everyone would know what a subgraph is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agree!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe here: https://thegraph.com/docs/en/developing/developer-faqs/#1-what-is-a-subgraph

website/pages/en/quick-start.mdx Outdated Show resolved Hide resolved
website/pages/en/quick-start.mdx Outdated Show resolved Hide resolved
website/pages/en/quick-start.mdx Outdated Show resolved Hide resolved
saihaj
saihaj approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@idalithb idalithb requested a review from saihaj August 21, 2024 00:11
@idalithb idalithb enabled auto-merge (squash) September 12, 2024 19:31
@idalithb idalithb disabled auto-merge September 12, 2024 19:32
@idalithb idalithb enabled auto-merge (squash) September 12, 2024 19:33
@idalithb idalithb merged commit aa721d8 into main Sep 12, 2024
4 checks passed
@idalithb idalithb deleted the quick-start branch September 12, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benface benface benface left review comments

@MichaelMacaulay MichaelMacaulay MichaelMacaulay approved these changes

@saihaj saihaj saihaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idalithb @benface @saihaj @MichaelMacaulay