Fix AS Migration Guide upcasting code snippet #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benface
reviewed
Feb 26, 2022
| @@ -91,19 +91,19 @@ maybeValue.aMethod(); | |||
| ولكن في الإصدار الأحدث ، نظرًا لأن القيمة nullable ، فإنها تتطلب منك التحقق ، مثل هذا: | |||
|
|
|||
| ```typescript | |||
| let maybeValue = load() | |||
| let maybeValue = load(); | |||
There was a problem hiding this comment.
As mentioned on Slack, we should fix the translations on Crowdin instead of in this PR. I will take care of it when this PR is merged, but can you please revert your changes to non-English files?
benface
reviewed
Feb 26, 2022
| @@ -91,19 +91,19 @@ maybeValue.aMethod(); | |||
| However on the newer version, because the value is nullable, it requires you to check, like this: | |||
|
|
|||
| ```typescript | |||
| let maybeValue = load() | |||
| let maybeValue = load(); | |||
There was a problem hiding this comment.
As mentioned on Slack, please run Prettier (with yarn prettier) and you'll see that the semicolons are automatically removed.
There was a problem hiding this comment.
I've removed all semicolons!
benface
reviewed
Feb 26, 2022
| ``` | ||
|
|
||
| ```typescript | ||
| // upcasting on class inheritance | ||
| class Bytes extends Uint8Array {} | ||
|
|
||
| let bytes = new Bytes(2) < Uint8Array > bytes // same as: bytes as Uint8Array |
There was a problem hiding this comment.
This is how Prettier will reformat these two lines of code (presumably a bug), so maybe change them to something like:
let bytes = new Bytes(2)
// `<Uint8Array>bytes` is equivalent to `bytes as Uint8Array`
benface
requested changes
Feb 26, 2022
evaporei
force-pushed
the
otavio/fix-migration-guide-fmt
branch
from
c6aaa69 to
cc418c2
Compare
3 tasks
benface
approved these changes
Feb 28, 2022
evaporei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point in the internationalization of the docs, some code got it's formatting broken.
This PR fixes this issue only for the AssemblyScript Migration Guide.
Some of the fixes include: