edits and small rewrites #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Next.js Bundle Analysis for @graphprotocol/docsThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Three Hundred Forty-two Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
benface
reviewed
May 29, 2024
benface
reviewed
May 29, 2024
| @@ -39,25 +41,25 @@ One thing to consider as well is choosing an Indexer wisely. If you choose an In | |||
|
|
|||
| ### Choosing a trustworthy Indexer with a fair reward payout for Delegators | |||
|
|
|||
| This is an important part to understand. First let's discuss three very important values, which are the Delegation Parameters. | |||
| This is an important aspect to understand. First, let's discuss three very important values, which are the Delegation Parameters. | |||
There was a problem hiding this comment.
This is slightly better than before, but there is still something strange about the wording here.
There was a problem hiding this comment.
Suggested change
| This is an important aspect to understand. First, let's discuss three very important values, which are the Delegation Parameters. | |
| This is an important aspect to understand. First, let's discuss three very important values: Delegation Parameters. |
There was a problem hiding this comment.
How do we feel about this instead?
Also, this is the only time I hear the term "Delegating Parameters," so I'm curious if it's supposed to be a proper noun.
There was a problem hiding this comment.
Good question for @bermchain
benface
reviewed
May 29, 2024
benface
reviewed
May 29, 2024
benface
reviewed
May 29, 2024
|
|
||
| ## Delegator FAQs and Bugs | ||
|
|
||
| ### MetaMask "Pending Transaction" Bug | ||
|
|
||
| **When I try to delegate my transaction in MetaMask appears as "Pending" or "Queued" for longer than expected. What should I do?** | ||
| **When I try to delegate my transaction in MetaMask, it appears as "Pending" or "Queued" for longer than expected. What should I do?** |
There was a problem hiding this comment.
This should probably be a heading (####). But since this is the only question in the FAQ section, maybe the whole section should be re-structured/re-thought? Or do we plan on adding more?
There was a problem hiding this comment.
Suggested change
| **When I try to delegate my transaction in MetaMask, it appears as "Pending" or "Queued" for longer than expected. What should I do?** | |
| ### When I try to delegate my transaction in MetaMask, it appears as "Pending" or "Queued" for longer than expected. What should I do? |
There was a problem hiding this comment.
Not for now, I was simply making small edits
benface
approved these changes
May 29, 2024
Co-authored-by: Benoît Rouleau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-made small edits to improve clarity and flow.