update Subgraph Studio archive policy #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Next.js Bundle Analysis for @graphprotocol/docsThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Four Hundred Fifty-one Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
benface
reviewed
May 24, 2024
| @@ -284,8 +284,13 @@ Developers will be notified by email if one of their subgraphs has been marked a | |||
|
|
|||
| ## Subgraph Studio subgraph archive policy | |||
|
|
|||
| When a new version of a subgraph is deployed, the previous version is archived (deleted from the graph-node DB). This only happens if the previous version is not published to The Graph's decentralized network. | |||
| A Subgraph version in Studio is archived if and only if it meets the following criteria: | |||
There was a problem hiding this comment.
Suggested change
| A Subgraph version in Studio is archived if and only if it meets the following criteria: | |
| A subgraph version in Studio is archived if and only if it meets the following criteria: |
benface
reviewed
May 24, 2024
| - The version was created 45 or more days ago | ||
| - The subgraph hasn't been queried in 30 days | ||
|
|
||
| In addition, when a new version is deployed, the N-2 version of the Subgraph is archived if it has not been published |
There was a problem hiding this comment.
Suggested change
| In addition, when a new version is deployed, the N-2 version of the Subgraph is archived if it has not been published | |
| In addition, when a new version is deployed, the N-2 version of the subgraph is archived if it has not been published. |
idalithb
reviewed
May 24, 2024
| - The version was created 45 or more days ago | ||
| - The subgraph hasn't been queried in 30 days | ||
|
|
||
| In addition, when a new version is deployed, the N-2 version of the Subgraph is archived if it has not been published |
There was a problem hiding this comment.
Suggested change
| In addition, when a new version is deployed, the N-2 version of the Subgraph is archived if it has not been published | |
| In addition, when a new version is deployed, if the subgraph has not been published, then the N-2 version of the subgraph is archived. |
There was a problem hiding this comment.
If my edit doesn't communicate the intended message, then feel free to disregard my suggestion; however, I attempted to make the conditional statement more clear.
It's typically good practice to use conditional statements, such as "if, then" first.
It's a user-friendly tech writing practice :)
There was a problem hiding this comment.
thanks for this, i did commit your suggestion as well!
idalithb
reviewed
May 24, 2024
| - The version was created 45 or more days ago | ||
| - The subgraph hasn't been queried in 30 days | ||
|
|
||
| In addition, when a new version is deployed, the N-2 version of the Subgraph is archived if it has not been published |
There was a problem hiding this comment.
If my edit doesn't communicate the intended message, then feel free to disregard my suggestion; however, I attempted to make the conditional statement more clear.
It's typically good practice to use conditional statements, such as "if, then" first.
It's a user-friendly tech writing practice :)
azf20
suggested changes
May 24, 2024
| @@ -281,6 +281,7 @@ We support the following scalars in our GraphQL API: | |||
| | `Int8` | An 8-byte signed integer, also known as a 64-bit signed integer, can store values in the range from -9,223,372,036,854,775,808 to 9,223,372,036,854,775,807. Prefer using this to represent `i64` from ethereum. | | |||
| | `BigInt` | Large integers. Used for Ethereum's `uint32`, `int64`, `uint64`, ..., `uint256` types. Note: Everything below `uint32`, such as `int32`, `uint24` or `int8` is represented as `i32`. | | |||
| | `BigDecimal` | `BigDecimal` High precision decimals represented as a significand and an exponent. The exponent range is from −6143 to +6144. Rounded to 34 significant digits. | | |||
| | `Timestamp` | Scalar for `timestamp` fields for timeseries and aggregations. | | |||
There was a problem hiding this comment.
This looks like it's the timestamp change from #683? may want to rebase from Master
There was a problem hiding this comment.
i have never done this. I was looking on google on how to do this but got super confused, can you help me with this?
There was a problem hiding this comment.
All good, I rebased for now but can walk you through it at a good moment
| @@ -284,8 +284,13 @@ Developers will be notified by email if one of their subgraphs has been marked a | |||
|
|
|||
| ## Subgraph Studio subgraph archive policy | |||
|
|
|||
| When a new version of a subgraph is deployed, the previous version is archived (deleted from the graph-node DB). This only happens if the previous version is not published to The Graph's decentralized network. | |||
| A subgraph version in Studio is archived if and only if it meets the following criteria: | |||
There was a problem hiding this comment.
This change looks like it's in the ar folder rather than the en?
There was a problem hiding this comment.
Wow nice catch, I missed that haha.
|
|
||
| When a subgraph version isn’t queried for over 45 days, that version is archived. | ||
| - The version is not published to the network (or pending publish) | ||
| - The version is not indexing a "special case" chain (polygon-zkevm, zksync-era, base, etc.) |
There was a problem hiding this comment.
I think this bullet no longer applies (there are no "special case" chains)
azf20
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.