[ix]: minor chore updates #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benface
reviewed
Apr 22, 2024
website/pages/en/about.mdx
Outdated
| @@ -44,4 +44,4 @@ The flow follows these steps: | |||
|
|
|||
| In the following sections we will go into more detail on how to define subgraphs, how to deploy them, and how to query data from the indexes that Graph Node builds. | |||
|
|
|||
| Before you start writing your own subgraph, you might want to have a look at the Graph Explorer and explore some of the subgraphs that have already been deployed. The page for each subgraph contains a playground that lets you query that subgraph's data with GraphQL. | |||
| Before you start writing your own subgraph, you might want to have a look at the [Graph Explorer](https://thegraph.com/explorer) and explore some of the subgraphs that have already been deployed. The page for each subgraph contains a playground that lets you query that subgraph's data with GraphQL. | |||
There was a problem hiding this comment.
Suggested change
| Before you start writing your own subgraph, you might want to have a look at the [Graph Explorer](https://thegraph.com/explorer) and explore some of the subgraphs that have already been deployed. The page for each subgraph contains a playground that lets you query that subgraph's data with GraphQL. | |
| Before you start writing your own subgraph, you might want to have a look at [Graph Explorer](https://thegraph.com/explorer) and explore some of the subgraphs that have already been deployed. The page for each subgraph contains a playground that lets you query that subgraph's data with GraphQL. |
Source: https://www.notion.so/edgeandnode/The-Graph-Style-Guide-70a1409024d84bfbb4eccdf0e49b7aa7?pvs=4#4baa7d6f012a43bbadfc1d7180d9c47e (thanks @bermchain!)
benface
reviewed
Apr 22, 2024
| @@ -182,7 +182,7 @@ Note: To support agile scaling, it is recommended that query and indexing concer | |||
|
|
|||
| #### Create a Google Cloud Project | |||
|
|
|||
| - Clone or navigate to the Indexer repository. | |||
| - Clone or navigate to the [Indexer repository](https://github.com/graphprotocol/indexer). | |||
|
|
|||
| - Navigate to the ./terraform directory, this is where all commands should be executed. | |||
There was a problem hiding this comment.
Suggested change
| - Navigate to the ./terraform directory, this is where all commands should be executed. | |
| - Navigate to the `./terraform` directory, this is where all commands should be executed. |
I know you didn't change this, but I saw it right below a line you changed so why not.
benface
reviewed
Apr 22, 2024
website/pages/en/sunrise.mdx
Outdated
| @@ -38,15 +38,15 @@ To upgrade a hosted service subgraph, you can visit the subgraph dashboard on th | |||
| 2. Select the receiving wallet (the wallet that will become the owner of the subgraph). | |||
| 3. Click the "Upgrade" button. | |||
|
|
|||
| Once your subgraph is published, the [upgrade Indexer](#what-is-an-upgrade-indexer) will begin serving queries on it, so you can begin making queries immediately, once you have generated an API key ([learn more](/cookbook/upgrading-a-subgraph/#what-next)). | |||
| Once your subgraph is published, the [Upgrade Indexer](#what-is-the-upgrade-indexer) will begin serving queries on it, so you can begin making queries immediately, once you have generated an API key ([learn more](/cookbook/upgrading-a-subgraph/#what-next)). | |||
There was a problem hiding this comment.
No, "upgrade" shouldn't be capitalized:
Suggested change
| Once your subgraph is published, the [Upgrade Indexer](#what-is-the-upgrade-indexer) will begin serving queries on it, so you can begin making queries immediately, once you have generated an API key ([learn more](/cookbook/upgrading-a-subgraph/#what-next)). | |
| Once your subgraph is published, the [upgrade Indexer](#what-is-the-upgrade-indexer) will begin serving queries on it, so you can begin making queries immediately, once you have generated an API key ([learn more](/cookbook/upgrading-a-subgraph/#what-next)). |
benface
requested changes
Apr 22, 2024
benface
approved these changes
Apr 22, 2024
azf20
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.