Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute check for sidebar links only on server #585

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

dimaMachina
Copy link
Contributor

@dimaMachina dimaMachina commented Jan 17, 2024

this piece of code will be stripped out by static analyzer since it will be evaluated to if (false) {... on client build. But if there is a mistake in _meta.js files -> next build will fail

@dimaMachina dimaMachina requested a review from a team as a code owner January 17, 2024 18:09
Copy link

📦 Next.js Bundle Analysis for @graphprotocol/docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 704.28 KB (🟡 +9 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@dimaMachina dimaMachina marked this pull request as draft January 17, 2024 18:23
@dimaMachina dimaMachina marked this pull request as ready for review January 17, 2024 18:23
@dimaMachina dimaMachina merged commit c494a9c into main Jan 17, 2024
3 checks passed
@dimaMachina dimaMachina deleted the remove-check-for-sidebar-links-on-client-build branch January 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants