Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename github token #23

Merged
merged 2 commits into from
Jan 11, 2022
Merged

rename github token #23

merged 2 commits into from
Jan 11, 2022

Conversation

nenadjaja
Copy link
Contributor

No description provided.

@nenadjaja nenadjaja requested a review from a team as a code owner January 11, 2022 19:21
@nenadjaja nenadjaja requested a review from benface January 11, 2022 19:21
@@ -20,7 +20,7 @@ jobs:
with:
registry: ghcr.io
username: Jannis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to update this as well @nenadjaja?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. I should update it to my account

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be another "secret" (environment variable), since it might change?

@nenadjaja nenadjaja merged commit 9599e4b into main Jan 11, 2022
@nenadjaja nenadjaja deleted the nena/secret branch January 11, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants