Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grafting Article #210

Merged
merged 7 commits into from
Nov 3, 2022
Merged

Conversation

t-proctor
Copy link
Contributor

Adding an article to the cookbook that describes grafting, as requested by @schmidsi

@t-proctor t-proctor requested a review from a team as a code owner September 28, 2022 16:09
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
@t-proctor t-proctor requested a review from schmidsi September 29, 2022 10:27
Copy link
Contributor

@schmidsi schmidsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @t-proctor just some small changes here

pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Outdated Show resolved Hide resolved
pages/en/cookbook/grafting.mdx Show resolved Hide resolved
@t-proctor
Copy link
Contributor Author

@azf20 @marceljay thank you for the feedback, have added fixes/comments based on it.

@azf20 azf20 merged commit f9676bd into graphprotocol:main Nov 3, 2022
@azf20
Copy link
Contributor

azf20 commented Nov 3, 2022

Thanks @t-proctor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants