Make external links open in a new tab by default #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically, you could use two leading slashes in an external link, but I wrote https://stackoverflow.com/questions/9646407/two-forward-slashes-in-a-url-src-href-attribute |
hasparus
approved these changes
Sep 2, 2022
@hasparus – Super good catch, but it looks like even Still, looking into this made me improve/simplify the code (removed 8 lines), so thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes links in
mdxfiles to automatically havetarget="_blank"if thehrefdoesn't start with/or#(meaning it's an external link, and we've been following the pattern of opening external links in new tabs on thegraph.com).