-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add developer role to decentralized network #177
Conversation
Adding a page that's an overview of what developers do on the decentralized network.
Co-authored-by: Benoît Rouleau <[email protected]>
Co-authored-by: Benoît Rouleau <[email protected]>
Rewrote developer page based on new format.
Wasn't sure if we plan on including the loom videos in the billing section or not. I've only seen YouTube videos elsewhere in the docs - can anyone clarify on that? |
@MichaelMacaulay – Yeah, we only have YouTube videos at the moment but I don't see why we couldn't have a Loom one. And it looks like they also support embedding! The code would be: <figure className="video-container">
<iframe
className="video-iframe"
src="https://www.loom.com/embed/b5fc533e48584cb694017392c80c75e0"
frameborder="0"
allowfullscreen
></iframe>
</div> BTW, I have on my list to create a |
@benface Awesome, thank you so much! |
Added the proper formatting for video links
Fixed the closing tags on the figure for videos
Added developer page to nav
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @MichaelMacaulay, just left two small comments. I also updated this PR to use the new VideoEmbed
component so you'll want to pull before making changes. Finally, the Loom URL was wrong; it was the "share" URL instead of the "embed" one so it wasn't working in an iframe; I fixed it.
Co-authored-by: Benoît Rouleau <[email protected]>
Co-authored-by: Benoît Rouleau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Added some notes about specific terms (publish vs. deploy), and I think there are some bits which are too detailed for a general overview about the role (and are covered, or should be covered in the "developer how to" parts of the documentation)
Incorporating Adam's feedback: -More high-level -Technical distinctions -Removing unfitting section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! A couple more suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested one change.
Otherwise it looks great.
Adding more detail on upgrading subgraphs based on Ørjan's comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Adding a page that's an overview of what developers do on the decentralized network.