Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer role to decentralized network #177

Merged
merged 15 commits into from
Sep 29, 2022
Merged

Add developer role to decentralized network #177

merged 15 commits into from
Sep 29, 2022

Conversation

MichaelMacaulay
Copy link
Contributor

Adding a page that's an overview of what developers do on the decentralized network.

Adding a page that's an overview of what developers do on the decentralized network.
@MichaelMacaulay MichaelMacaulay requested a review from a team as a code owner July 27, 2022 22:09
@MichaelMacaulay MichaelMacaulay changed the title Add developer role to decentralized network [WIP] Add developer role to decentralized network Jul 28, 2022
MichaelMacaulay and others added 3 commits August 2, 2022 09:18
Rewrote developer page based on new format.
@MichaelMacaulay
Copy link
Contributor Author

Wasn't sure if we plan on including the loom videos in the billing section or not. I've only seen YouTube videos elsewhere in the docs - can anyone clarify on that?

@benface
Copy link
Contributor

benface commented Aug 3, 2022

I've only seen YouTube videos elsewhere in the docs - can anyone clarify on that?

@MichaelMacaulay – Yeah, we only have YouTube videos at the moment but I don't see why we couldn't have a Loom one. And it looks like they also support embedding! The code would be:

<figure className="video-container">
  <iframe
    className="video-iframe"
    src="https://www.loom.com/embed/b5fc533e48584cb694017392c80c75e0"
    frameborder="0"
    allowfullscreen
  ></iframe>
</div>

BTW, I have on my list to create a <Video /> component which will simplify the code to add to Markdown files.

@MichaelMacaulay
Copy link
Contributor Author

@benface Awesome, thank you so much!

Added the proper formatting for video links
Fixed the closing tags on the figure for videos
Added developer page to nav
@MichaelMacaulay MichaelMacaulay changed the title [WIP] Add developer role to decentralized network Add developer role to decentralized network Aug 10, 2022
Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @MichaelMacaulay, just left two small comments. I also updated this PR to use the new VideoEmbed component so you'll want to pull before making changes. Finally, the Loom URL was wrong; it was the "share" URL instead of the "embed" one so it wasn't working in an iframe; I fixed it.

Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Added some notes about specific terms (publish vs. deploy), and I think there are some bits which are too detailed for a general overview about the role (and are covered, or should be covered in the "developer how to" parts of the documentation)

pages/en/network/developing.mdx Outdated Show resolved Hide resolved
pages/en/network/developing.mdx Outdated Show resolved Hide resolved
pages/en/network/developing.mdx Outdated Show resolved Hide resolved
pages/en/network/developing.mdx Outdated Show resolved Hide resolved
pages/en/network/developing.mdx Outdated Show resolved Hide resolved
pages/en/network/developing.mdx Outdated Show resolved Hide resolved
pages/en/network/developing.mdx Outdated Show resolved Hide resolved
Incorporating Adam's feedback:
-More high-level
-Technical distinctions
-Removing unfitting section
@MichaelMacaulay MichaelMacaulay requested a review from azf20 August 19, 2022 21:15
Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A couple more suggestions

pages/en/network/developing.mdx Outdated Show resolved Hide resolved
pages/en/network/developing.mdx Outdated Show resolved Hide resolved
pages/en/network/developing.mdx Outdated Show resolved Hide resolved
pages/en/network/developing.mdx Outdated Show resolved Hide resolved
pages/en/network/developing.mdx Outdated Show resolved Hide resolved
Fixing a few things
@MichaelMacaulay MichaelMacaulay requested a review from azf20 August 22, 2022 22:01
Copy link
Contributor

@Web3Slimchance Web3Slimchance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested one change.
Otherwise it looks great.

pages/en/network/developing.mdx Outdated Show resolved Hide resolved
Adding more detail on upgrading subgraphs based on Ørjan's comment
Copy link
Contributor

@Web3Slimchance Web3Slimchance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@azf20 azf20 merged commit 52413b2 into main Sep 29, 2022
@azf20 azf20 deleted the developer-role branch September 29, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants