Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☀️ Graph Horizon and Subgraph Service ☀️ #944

Open
wants to merge 459 commits into
base: main
Choose a base branch
from
Open

Conversation

pcarranzav
Copy link
Member

No description provided.

Copy link

openzeppelin-code bot commented Feb 20, 2024

☀️ Graph Horizon and Subgraph Service ☀️

Generated at commit: 0e9f9d338b419ac82176e8ca3c5ae35e9c0ee96f

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
39
60
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@tmigone tmigone changed the title [WIP/Experimental] Horizon draft changes [WIP/Experimental] BREAKING CHANGE: Horizon draft changes Feb 20, 2024
Copy link

socket-security bot commented Feb 21, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteCI
Critical CVE npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.55%. Comparing base (03d8d2a) to head (0e9f9d3).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ges/contracts/contracts/rewards/RewardsManager.sol 76.00% 6 Missing ⚠️
packages/contracts/contracts/staking/Staking.sol 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
- Coverage   92.83%   92.55%   -0.29%     
==========================================
  Files          47       47              
  Lines        2415     2430      +15     
  Branches      438      438              
==========================================
+ Hits         2242     2249       +7     
- Misses        173      181       +8     
Flag Coverage Δ
unittests 92.55% <84.31%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmigone tmigone force-pushed the horizon branch 2 times, most recently from 76aa677 to 33b5790 Compare March 14, 2024 18:40
Copy link

socket-security bot commented Mar 14, 2024

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@nodelib/[email protected], npm/@nodelib/[email protected], npm/@nodelib/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@tmigone tmigone force-pushed the horizon branch 4 times, most recently from 1b27dfa to cae2490 Compare March 21, 2024 20:37
@tmigone tmigone changed the title [WIP/Experimental] BREAKING CHANGE: Horizon draft changes [WIP] Horizon draft changes Apr 12, 2024
@tmigone tmigone changed the title [WIP] Horizon draft changes [WIP] Horizon changes Apr 12, 2024
@tmigone tmigone changed the title [WIP] Horizon changes [WIP] Graph Horizon May 17, 2024
Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for now - still reviewing

packages/contracts/contracts/arbitrum/ITokenGateway.sol Outdated Show resolved Hide resolved
packages/horizon/README.md Outdated Show resolved Hide resolved
Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, still reviewing...

Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moar

Copy link
Member Author

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more comments - finished going through the main Solidity code

packages/horizon/package.json Outdated Show resolved Hide resolved
packages/subgraph-service/contracts/DisputeManager.sol Outdated Show resolved Hide resolved
@tmigone tmigone marked this pull request as ready for review June 7, 2024 23:56
@tmigone tmigone changed the title [WIP] Graph Horizon Graph Horizon and Subgraph Service Jun 7, 2024
@tmigone tmigone changed the title Graph Horizon and Subgraph Service ❄️ Graph Horizon and Subgraph Service ❄️ Jun 8, 2024
@tmigone tmigone changed the title ❄️ Graph Horizon and Subgraph Service ❄️ ☀️ Graph Horizon and Subgraph Service ☀️ Sep 6, 2024
* chore: add unit tests

* fix: rebase cleanup

* chore: dispute manager tests fixes

* chore: dispute manager test fixes

* chore: refactoring subgraph service unit tests

* chore: subgraph service test fixes
tmigone and others added 30 commits February 6, 2025 17:42
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants